Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: support create sharding cluster #434

Closed
wants to merge 2 commits into from
Closed

bugfix: support create sharding cluster #434

wants to merge 2 commits into from

Conversation

yipeng1030
Copy link
Contributor

@yipeng1030 yipeng1030 commented Aug 29, 2024 •
edited
Loading

fix #428

Change

  • Support verifying componnetDef from shardingSpecs of the cluster.

Test

  • After fixed, a redis cluster with mode "cluster" can be created correctly.
  1. Edit go build configuration.
image
  1. Run the kbcli with commands and get result.
image
  1. Check the phase of redis cluster.
image

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Aug 29, 2024
@apecloud-bot
Copy link
Collaborator

This branch name is not following the standards: feature/|bugfix/|release/|hotfix/|support/|releasing/|dependabot/

1 similar comment
@apecloud-bot
Copy link
Collaborator

This branch name is not following the standards: feature/|bugfix/|release/|hotfix/|support/|releasing/|dependabot/

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 44.87%. Comparing base (0657641) to head (b0dea88).

Files with missing lines Patch % Lines
pkg/cmd/cluster/create_subcmds.go 27.27% 7 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #434      +/-   ##
==========================================
- Coverage   44.89%   44.87%   -0.02%     
==========================================
  Files         157      157              
  Lines       23000    23007       +7     
==========================================
  Hits        10325    10325              
- Misses      11443    11449       +6     
- Partials     1232     1233       +1
Flag Coverage Δ
unittests 44.87% <27.27%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot
Copy link
Collaborator

This branch name is not following the standards: feature/|bugfix/|release/|hotfix/|support/|releasing/|dependabot/

1 similar comment
@apecloud-bot
Copy link
Collaborator

This branch name is not following the standards: feature/|bugfix/|release/|hotfix/|support/|releasing/|dependabot/

@yipeng1030 yipeng1030 closed this Aug 29, 2024
@github-actions github-actions bot added this to the Release 0.9.1 milestone Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nayutah nayutah Awaiting requested review from nayutah nayutah is a code owner

@ldming ldming Awaiting requested review from ldming ldming is a code owner

@heng4fun heng4fun Awaiting requested review from heng4fun heng4fun is a code owner

@free6om free6om Awaiting requested review from free6om free6om is a code owner

@wangyelei wangyelei Awaiting requested review from wangyelei wangyelei is a code owner

@leon-inf leon-inf Awaiting requested review from leon-inf leon-inf is a code owner

@1aal 1aal Awaiting requested review from 1aal 1aal is a code owner

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
Release 0.9.1
Development

Successfully merging this pull request may close these issues.

[BUG] failed to create redis cluster
3 participants
@yipeng1030 @apecloud-bot @codecov-commenter